Bugfix/66 gracefull crash handling #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/66-gracefull-crash-handling
branch
from
30665ea to
116a122
Compare
3 tasks
Pietfried
requested changes
May 5, 2024
AssemblyJohn
force-pushed
the
bugfix/66-gracefull-crash-handling
branch
from
a4efe1e to
422be31
Compare
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/66-gracefull-crash-handling
branch
from
422be31 to
3055563
Compare
|
Comments have been addressed, please, re-review. |
Pietfried
requested changes
May 7, 2024
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
bugfix/66-gracefull-crash-handling
branch
from
0f4f8f1 to
e68e61f
Compare
Signed-off-by: AssemblyJohn <[email protected]>
|
Comments implemented, re-review required. |
Pietfried
requested changes
May 7, 2024
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
|
Comments solved, request re-review. |
Signed-off-by: AssemblyJohn <[email protected]>
Pietfried
approved these changes
May 10, 2024
hikinggrass
added a commit
that referenced
this pull request
May 10, 2024
When #604 was merged it did not point to a git hash on the main branch but on a now deleted feature branch Signed-off-by: Kai-Uwe Hermann <[email protected]>
4 tasks
hikinggrass
added a commit
that referenced
this pull request
May 10, 2024
When #604 was merged it did not point to a git hash on the main branch but on a now deleted feature branch Signed-off-by: Kai-Uwe Hermann <[email protected]>
christopher-davis-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
May 30, 2024
* Updated interface usage * Updated dependencies for new interface * Fixed mocks * Updated deps * Updated native interface usage * Updated deps * Updated for comments * Implemented code comments * Updated dependencies * Updated some comments * Update legacy websocket++ * Updated deps --------- Signed-off-by: AssemblyJohn <[email protected]>
christopher-davis-afs
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
May 30, 2024
When EVerest#604 was merged it did not point to a git hash on the main branch but on a now deleted feature branch Signed-off-by: Kai-Uwe Hermann <[email protected]>
drmrd
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Jun 4, 2024
* Updated interface usage * Updated dependencies for new interface * Fixed mocks * Updated deps * Updated native interface usage * Updated deps * Updated for comments * Implemented code comments * Updated dependencies * Updated some comments * Update legacy websocket++ * Updated deps --------- Signed-off-by: AssemblyJohn <[email protected]> Signed-off-by: Daniel Moore <[email protected]>
drmrd
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Jun 4, 2024
When EVerest#604 was merged it did not point to a git hash on the main branch but on a now deleted feature branch Signed-off-by: Kai-Uwe Hermann <[email protected]> Signed-off-by: Daniel Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Interface update for CSR requests and other libevse-security crash handlings.
Issue ticket number and link
EVerest/libevse-security#70
Supersedes: #596 as it includes all changes made there.
Checklist before requesting a review